Re: ARC backport for stable 3.12

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 25 June 2014 07:24 PM, Jiri Slaby wrote:
> On 06/25/2014 03:35 PM, Vineet Gupta wrote:
>> On Wednesday 25 June 2014 07:01 PM, Jiri Slaby wrote:
>>> ....
>>> {
>>>      pgtable_t pte_pg;
>>> +    struct page *page;
>>>
>>>      pte_pg = __get_free_pages(GFP_KERNEL | __GFP_REPEAT, __get_order_pte());
>>>      if (pte_pg) {
>>>          memzero((void *)pte_pg, PTRS_PER_PTE * 4);
>>> -        pgtable_page_ctor(virt_to_page(pte_pg));
>>> +        page = virt_to_page(pte_pg);
>>> +        pgtable_page_ctor(page);
>>> And now, it does not fix anything, so this does not fulfill the stable
>>> rules. I cannot take it "as-is", sorry.
>> What do u mean ? It changes pgtable_page_ctor() arg to be a lvalue since RT kernel
>> has this. Current code fails to build, while fixed code builds//boots.
>>
>> +#define pgtable_page_ctor(page)                                \
>> +do {                                                   \
>> +       page = __pgtable_page_ctor(page);               \
>> +} while (0)
> But if this is an RT code, it is a bug and should be fixed, right? Or is
> this an excerpt from the stable tree?

This is excerpt from RT tree.

Thx,
-Vineet

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]