On 12.11.2021 22:47, Stefano Stabellini wrote: > --- a/drivers/xen/xenbus/xenbus_probe.c > +++ b/drivers/xen/xenbus/xenbus_probe.c > @@ -983,8 +983,10 @@ static int __init xenbus_init(void) > */ > proc_create_mount_point("xen"); > #endif > + return err; Personally I think such cases would better be "return 0". With that done here, err's initializer could (imo should) then also be dropped. Jan > out_error: > + xen_store_domain_type = XS_UNKNOWN; > return err; > } > >