Re: [PATCH] tipc: check for null after calling kmemdup

[Tadeusz Struk <tadeusz.struk@xxxxxxxxxx>]

On 11/12/21 20:13, Jakub Kicinski wrote:
> > > @@ -597,6 +597,11 @@ static int tipc_aead_init(struct tipc_aead **aead, struct tipc_aead_key *ukey,
> > >    	tmp->cloned = NULL;
> > >    	tmp->authsize = TIPC_AES_GCM_TAG_SIZE;
> > >    	tmp->key = kmemdup(ukey, tipc_aead_key_size(ukey), GFP_KERNEL);
> > > +	if (!tmp->key) {
> > > +		free_percpu(tmp->tfm_entry);
> > > +		kfree_sensitive(tmp);
> > > +		return -ENOMEM;
> > > +	}
> > Acked-by: Jon Maloy<jmaloy@xxxxxxxxxx>
> Hm, shouldn't we free all the tfm entries here?

Right, I think we just need to call tipc_aead_free(&tmp->rcu);
here and return an error.

--
Thanks,
Tadeusz