Hi Mark. Replying inline (https://en.wikipedia.org/wiki/Posting_style#Interleaved_style ), as that's the norm and kinda expected on Linux kernel mailing lists: On 11.11.21 00:11, Mark Boddington wrote: > And also > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c?h=linux-5.15.y&id=f02abeb0779700c308e661a412451b38962b8a0b > > Maybe if the function is called during resume() without being called > during init(), bad things happen??? Have you tried to revert any of the patches you suspect to cause this and see if things improve? And BTW: did 5.15 (aka 5.15.0) work? Or was some process to resolve this made already somewhere else and I just missed it? Ciao, Thorsten (with his Linux kernel regression tracker hat on) #regzbot poke > On 10/11/2021 23:02, Mark Boddington wrote: >> I think I've found the problem. >> >> The amdgpu_amdkfd_resume_iommu(adev) call has been moved around a few >> times recently, but in 5.15.1 it's been removed completely. >> >> I think reverting this patch fixes the issue: >> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c?h=linux-5.15.y&id=f17dca0ab3f38b19c0f1b935f417f62d4a528723 >> >> >> See also: >> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c?h=linux-5.15.y&id=714d9e4574d54596973ee3b0624ee4a16264d700 >> >> >> Cheers, >> >> Mark >> >> On 10/11/2021 17:38, Greg KH wrote: >>> On Wed, Nov 10, 2021 at 04:27:39PM +0000, Mark Boddington wrote: >>>> Hi all, >>>> >>>> I run the mainline Linux kernel on Ubuntu 20.04, built from >>>> https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.15.1/ >>>> >>>> There appears to be a regression in 5.15.1 which causes the GPU to >>>> fail to >>>> resume after power saving. >>>> >>>> Could it be this change??: >>>> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c?h=v5.15.1&id=8af3a335b5531ca3df0920b1cca43e456cd110ad >>>> >>> If you revert it, does it solve the problem for you? >>> >>> If not, what kernel version did work for you with this hardware? >>> >>> thanks, >>> >>> greg k-h > >