Re: [PATCH] drm/i915: Remove memory frequency calculation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 04, 2021 at 12:30:18AM +0000, Souza, Jose wrote:
> On Wed, 2021-11-03 at 10:46 +0100, Greg KH wrote:
> > On Mon, Nov 01, 2021 at 11:32:30AM -0700, José Roberto de Souza wrote:
> > > This memory frequency calculated is only used to check if it is zero,
> > > what is not useful as it will never actually be zero.
> > > 
> > > Also the calculation is wrong, we should be checking other bit to
> > > select the appropriate frequency multiplier while this code is stuck
> > > with a fixed multiplier.
> > > 
> > > So here dropping it as whole.
> > > 
> > > v2:
> > > - Also remove memory frequency calculation for gen9 LP platforms
> > > 
> > > Cc: <stable@xxxxxxxxxxxxxxx> # 5.14-stable
> > > Cc: Yakui Zhao <yakui.zhao@xxxxxxxxx>
> > > Cc: Matt Roper <matthew.d.roper@xxxxxxxxx>
> > > Fixes: 5d0c938ec9cc ("drm/i915/gen11+: Only load DRAM information from pcode")
> > > Signed-off-by: José Roberto de Souza <jose.souza@xxxxxxxxx>
> > > Reviewed-by: Matt Roper <matthew.d.roper@xxxxxxxxx>
> > > Link: https://patchwork.freedesktop.org/patch/msgid/20211013010046.91858-1-jose.souza@xxxxxxxxx
> > > (cherry picked from commit 83f52364b15265aec47d07e02b0fbf4093ab8554)
> > 
> > There is no such commit in Linus's tree.
> > 
> > What commit is this that is being backported?
> 
> It is on Linus's tree:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=83f52364b15265aec47d07e02b0fbf4093ab8554

Ah, no, this is REALLY commit 59be177a909a ("drm/i915: Remove memory
frequency calculation"), which came in 5.15.

{sigh}

Someday the i915 developers will fix up how they reference git sha ids
and not do things that "look into the future" which causes so many
confusions over the years.

ugh.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux