On Wed, Nov 03, 2021 at 10:19:21AM -0700, Tadeusz Struk wrote: > On 11/3/21 10:09, Christoph Hellwig wrote: >>> + if (hdr->cmd_len < 6) >>> + return -EMSGSIZE; >> The checks looks good, but I'd be tempted to place it next to the >> other check on hdr->cmd_len in the caller. > > Do you mean in sg_io()? > I don't mind changing it, but putting the check here in > scsi_fill_sghdr_rq() was suggested by Douglas (cc'ed now). Ok, let's keep it that way for now.
