This is a note to let you know that I've just added the patch titled
USB: cdc-acm: fix I/O after failed open
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-cdc-acm-fix-i-o-after-failed-open.patch
and it can be found in the queue-3.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From e4c36076c2a6195ec62c35b03c3fde84d0087dc8 Mon Sep 17 00:00:00 2001
From: Johan Hovold <jhovold@xxxxxxxxx>
Date: Mon, 26 May 2014 19:23:44 +0200
Subject: USB: cdc-acm: fix I/O after failed open
From: Johan Hovold <jhovold@xxxxxxxxx>
commit e4c36076c2a6195ec62c35b03c3fde84d0087dc8 upstream.
Make sure to kill any already submitted read urbs on read-urb submission
failures in open in order to prevent doing I/O for a closed port.
Fixes: 088c64f81284 ("USB: cdc-acm: re-write read processing")
Signed-off-by: Johan Hovold <jhovold@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/usb/class/cdc-acm.c | 3 +++
1 file changed, 3 insertions(+)
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -506,6 +506,7 @@ static int acm_port_activate(struct tty_
{
struct acm *acm = container_of(port, struct acm, port);
int retval = -ENODEV;
+ int i;
dev_dbg(&acm->control->dev, "%s\n", __func__);
@@ -554,6 +555,8 @@ static int acm_port_activate(struct tty_
return 0;
error_submit_read_urbs:
+ for (i = 0; i < acm->rx_buflimit; i++)
+ usb_kill_urb(acm->read_urbs[i]);
acm->ctrlout = 0;
acm_set_control(acm, acm->ctrlout);
error_set_control:
Patches currently in stable-queue which might be from jhovold@xxxxxxxxx are
queue-3.14/usb-cdc-acm-fix-i-o-after-failed-open.patch
queue-3.14/usb-cdc-acm-fix-write-and-resume-race.patch
queue-3.14/usb-cdc-acm-fix-runtime-pm-for-control-messages.patch
queue-3.14/usb-cdc-acm-fix-broken-runtime-suspend.patch
queue-3.14/usb-cdc-acm-fix-potential-urb-leak-and-pm-imbalance-in-write.patch
queue-3.14/usb-cdc-acm-fix-runtime-pm-imbalance-at-shutdown.patch
queue-3.14/usb-cdc-acm-fix-shutdown-and-suspend-race.patch
queue-3.14/usb-cdc-acm-fix-write-and-suspend-race.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html