Hi Petr, On Tue, Oct 19, 2021 at 09:24:44AM +0200, Petr Benes wrote: > On Mon, 18 Oct 2021 at 13:38, Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote: > > > > On 18/10/2021 13:28, Oleksij Rempel wrote: > > > Hi Michal, > > > > > > I hope you have seen this patch: > > > https://lore.kernel.org/all/20210924115032.29684-1-o.rempel@xxxxxxxxxxxxxx/ > > > > > > Are there any reason why this was ignored? > > > > No reasons, I was waiting for some tags before merging it. But I forget > > about it when reviewing the current patch. > > Tested Oleksij's patch. It works OK. A question arose. Does it require > CONFIG_PM=y? > If this condition is mandatory and the requirement is valid, Kconfig > should be changed accordingly. > I'm not able to verify it works without PM, seems it doesn't. If CONFIG_PM=n, all pm_runtime_* will do nothing and the imx_thermal core will stay enabled, see: +/* the core was configured and enabled just before */ +pm_runtime_set_active(&pdev->dev); +pm_runtime_enable(data->dev); Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
