On Thu, Oct 14, 2021 at 05:58:19PM +0200, Marek Behún wrote: > From: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> > > commit bb914088bd8a91c382f54d469367b2e5508b5493 upstream. > > If the heartbeat module param is not specified we would get an error > message > > watchdog: f1020300.watchdog: driver supplied timeout (4294967295) out of range > watchdog: f1020300.watchdog: falling back to default timeout (171) > > This is because we were initialising heartbeat to -1. By removing the > initialisation (thus letting the C run time initialise it to 0) we > silence the warning message and the default timeout is still used. > > Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> > Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> > Link: https://lore.kernel.org/r/20200313031312.1485-1-chris.packham@xxxxxxxxxxxxxxxxxxx > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> > Signed-off-by: Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Marek Behún <kabel@xxxxxxxxxx> > --- > The error message appears also in 5.4, but not 4.19. So apply also for 5.4. Now queued up, thanks. greg k-h