On Tue, 05 Oct 2021, Aditya Garg wrote: > Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake > PCH-N UART controler present on the MacBookPro16,2. > > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Orlando Chamberlain <redecorating@xxxxxxxxxxxxxx> Who is the author of this patch? Why hasn't the submitter signed it off? > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > v3->v4: reviewed-by line > > drivers/mfd/intel-lpss-pci.c > | 2 ++ > 1 file changed, 2 insertions(+) > > > diff This is not a format I recognise. Did you use `git send-email` to submit this? > --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c > index c54d19fb184c..a872b4485eac 100644 > --- a/drivers/mfd/intel-lpss-pci.c > +++ b/drivers/mfd/intel-lpss-pci.c > > @@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = { > > { PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info }, > { PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info }, > { PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info }, > > + /* ICL-N */ > + { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info }, > > /* TGL-H */ > { PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info }, > { PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info }, -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog