Re: Patch "netlink: rate-limit leftover bytes warning and print process name" has been added to the 3.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 18, 2014 at 09:57:00PM -0700, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> 
> This is a note to let you know that I've just added the patch titled
> 
>     netlink: rate-limit leftover bytes warning and print process name
> 
> to the 3.4-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      netlink-rate-limit-leftover-bytes-warning-and-print-process-name.patch
> and it can be found in the queue-3.4 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@xxxxxxxxxxxxxxx> know about it.
> 
> 
> >From foo@baz Wed Jun 18 21:53:03 PDT 2014
> From: Michal Schmidt <mschmidt@xxxxxxxxxx>
> Date: Mon, 2 Jun 2014 18:25:02 +0200
> Subject: netlink: rate-limit leftover bytes warning and print process name
> Status: RO
> Content-Length: 1053
> Lines: 34
> 
> From: Michal Schmidt <mschmidt@xxxxxxxxxx>
> 
> [ Upstream commit bfc5184b69cf9eeb286137640351c650c27f118a ]
> 
> Any process is able to send netlink messages with leftover bytes.
> Make the warning rate-limited to prevent too much log spam.
> 
> The warning is supposed to help find userspace bugs, so print the
> triggering command name to implicate the buggy program.
> 
> [v2: Use pr_warn_ratelimited instead of printk_ratelimited.]
> 
> Signed-off-by: Michal Schmidt <mschmidt@xxxxxxxxxx>
> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
>  lib/nlattr.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/lib/nlattr.c
> +++ b/lib/nlattr.c
> @@ -197,8 +197,8 @@ int nla_parse(struct nlattr **tb, int ma
>  	}
>  
>  	if (unlikely(rem > 0))
> -		printk(KERN_WARNING "netlink: %d bytes leftover after parsing "
> -		       "attributes.\n", rem);
> +		pr_warn_ratelimited("netlink: %d bytes leftover after parsing attributes in process `%s'.\n",
> +				    rem, current->comm);
>  
>  	err = 0;
>  errout:
> 
> 
> Patches currently in stable-queue which might be from mschmidt@xxxxxxxxxx are
> 
> queue-3.4/netlink-rate-limit-leftover-bytes-warning-and-print-process-name.patch

Doh, I committed the wrong version, now I have the fixed version in the
tree...
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]