On Thu, Sep 30, 2021 at 10:22:42AM +0000, Pawel Laszczak wrote:
On Thu, Sep 30, 2021 at 11:42:17AM +0200, Pawel Laszczak wrote:
From: Pawel Laszczak <pawell@xxxxxxxxxxx>
commit b69ec50b3e55c4b2a85c8bc46763eaf33060584 upstream
For DEV_VER_V3 version there exist race condition between clearing
ep_sts.EP_STS_TRBERR and setting ep_cmd.EP_CMD_DRDY bit.
Setting EP_CMD_DRDY will be ignored by controller when
EP_STS_TRBERR is set. So, between these two instructions we have
a small time gap in which the EP_STS_TRBERR can be set. In such case
the transfer will not start after setting doorbell.
Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
cc: <stable@xxxxxxxxxxxxxxx> # 5.4.x
Tested-by: Aswath Govindraju <a-govindraju@xxxxxx>
Reviewed-by: Aswath Govindraju <a-govindraju@xxxxxx>
Signed-off-by: Pawel Laszczak <pawell@xxxxxxxxxxx>
---
drivers/usb/cdns3/gadget.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
What kernel(s) are you wanting this applied to?
To 5.4. I added information in cc: <stable@xxxxxxxxxxxxxxx> tag (# 5.4.x) .
Is it sufficient or not? I ask because I need to post this fix also to v5.10.
I queued this up for both 5.10 and 5.4, thanks.
The issue seems to be that in the upstream patch you explicitly stated
to go only to 5.12:
cc: <stable@xxxxxxxxxxxxxxx> # 5.12.x
Was that your intent?
--
Thanks,
Sasha
