Hi! > > > > Commit 76c47d1449fc ("gpio: mpc8xxx: Add ACPI support") has switched to a > > > > managed version when dealing with 'mpc8xxx_gc->regs'. So the corresponding > > > > 'iounmap()' call in the error handling path and in the remove should be > > > > removed to avoid a double unmap. > > > > > > This is wrong, AFAICT. 5.10 does not have 76c47d1449fc ("gpio: > > > mpc8xxx: Add ACPI support") so iounmap is still neccessary and this > > > adds a memory leak. > > > > Ah, but then I have to drop 889a1b3f35db ("gpio: mpc8xxx: Use > > 'devm_gpiochip_add_data()' to simplify the code and avoid a leak") from > > the 5.10 queue as it depends on this one. > > > > Can you provide a working backport of that commit so that I can queue up > > the fix? > > Oh nevermind, I fixed it up myself. Thank you! Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Attachment:
signature.asc
Description: Digital signature