Hi! > Joakim Zhang reports that Wake-on-Lan with the stmmac ethernet driver broke > when moving the incorrect handling of mac link state out of mac_config(). > This reason this breaks is because the stmmac's WoL is handled by the MAC > rather than the PHY, and phylink doesn't cater for that scenario. > > This patch adds the necessary phylink code to handle suspend/resume events > according to whether the MAC still needs a valid link or not. This is the > barest minimum for this support. This adds functions that end up being unused in 5.10. AFAICT we do not need this in 5.10. Best regards, Pavel > +++ b/include/linux/phylink.h > @@ -446,6 +446,9 @@ void phylink_mac_change(struct phylink *, bool up); > void phylink_start(struct phylink *); > void phylink_stop(struct phylink *); > > +void phylink_suspend(struct phylink *pl, bool mac_wol); > +void phylink_resume(struct phylink *pl); > + > void phylink_ethtool_get_wol(struct phylink *, struct ethtool_wolinfo *); > int phylink_ethtool_set_wol(struct phylink *, struct ethtool_wolinfo *); -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Attachment:
signature.asc
Description: PGP signature
