Marek Vasut <marex@xxxxxxx> wrote:
> The module parameters are missing dev_oper_mode 12, BT classic alone,
> add it. Moreover, the parameters encode newlines, which ends up being
> printed malformed e.g. by modinfo, so fix that too.
>
> However, the module parameter string is duplicated in both USB and SDIO
> modules and the dev_oper_mode mode enumeration in those module parameters
> is a duplicate of macros used by the driver. Furthermore, the enumeration
> is confusing.
>
> So, deduplicate the module parameter string and use __stringify() to
> encode the correct mode enumeration values into the module parameter
> string. Finally, replace 'Wi-Fi' with 'Wi-Fi alone' and 'BT' with
> 'BT classic alone' to clarify what those modes really mean.
>
> Fixes: 898b255339310 ("rsi: add module parameter operating mode")
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
> Cc: Amitkumar Karwar <amit.karwar@xxxxxxxxxxxxxxxxxx>
> Cc: Angus Ainslie <angus@xxxxxxxx>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> Cc: Karun Eagalapati <karun256@xxxxxxxxx>
> Cc: Martin Fuzzey <martin.fuzzey@flowbird.group>
> Cc: Martin Kepplinger <martink@xxxxxxxxx>
> Cc: Prameela Rani Garnepudi <prameela.j04cs@xxxxxxxxx>
> Cc: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@xxxxxxx>
> Cc: Siva Rebbagondla <siva8118@xxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.17+
Patch applied to wireless-drivers-next.git, thanks.
31f97cf9f0c3 rsi: Fix module dev_oper_mode parameter description
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210916144245.10181-1-marex@xxxxxxx/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
