On Mon, Sep 13, 2021 at 2:15 PM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > > Sorry wrong diff: Well, this second diff was seriously whitespace-damaged and hard to read, but while it seems to be the same number of lines, it sure looks a lot more readable in this format. Except I think that default: dividend / divisor); should really have parentheses around both of those macro arguments. That's a preexisting problem, but it should be fixed while at it. I'm also not sure why that (again, preexisting) BUILD_BUG_ON_MSG() only checks the size of the dividend, not the divisor. Very strange. But probably not worth worrying about. Linus