This is a note to let you know that I've just added the patch titled
target: Fix alua_access_state attribute OOPs for un-configured devices
to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
target-fix-alua_access_state-attribute-oops-for-un-configured-devices.patch
and it can be found in the queue-3.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From f1453773514bb8b0bba0716301e8c8f17f8d39c7 Mon Sep 17 00:00:00 2001
From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
Date: Fri, 6 Jun 2014 00:52:57 -0700
Subject: target: Fix alua_access_state attribute OOPs for un-configured devices
From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
commit f1453773514bb8b0bba0716301e8c8f17f8d39c7 upstream.
This patch fixes a OOPs where an attempt to write to the per-device
alua_access_state configfs attribute at:
/sys/kernel/config/target/core/$HBA/$DEV/alua/$TG_PT_GP/alua_access_state
results in an NULL pointer dereference when the backend device has not
yet been configured.
This patch adds an explicit check for DF_CONFIGURED, and fails with
-ENODEV to avoid this case.
Reported-by: Chris Boot <crb@xxxxxxxxxxxxxxxxxxxxx>
Reported-by: Philip Gaw <pgaw@xxxxxxxxxxxxxxx>
Cc: Chris Boot <crb@xxxxxxxxxxxxxxxxxxxxx>
Cc: Philip Gaw <pgaw@xxxxxxxxxxxxxxx>
Signed-off-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/target/target_core_configfs.c | 5 +++++
1 file changed, 5 insertions(+)
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -2034,6 +2034,11 @@ static ssize_t target_core_alua_tg_pt_gp
" tg_pt_gp ID: %hu\n", tg_pt_gp->tg_pt_gp_valid_id);
return -EINVAL;
}
+ if (!(dev->dev_flags & DF_CONFIGURED)) {
+ pr_err("Unable to set alua_access_state while device is"
+ " not configured\n");
+ return -ENODEV;
+ }
ret = strict_strtoul(page, 0, &tmp);
if (ret < 0) {
Patches currently in stable-queue which might be from nab@xxxxxxxxxxxxxxx are
queue-3.10/iscsi-target-fix-wrong-buffer-buffer-overrun-in-iscsi_change_param_value.patch
queue-3.10/target-allow-read_capacity-opcode-in-alua-standby-access-state.patch
queue-3.10/iser-target-fix-multi-network-portal-shutdown-regression.patch
queue-3.10/target-iscsi-iser-avoid-accepting-transport-connections-during-stop-stage.patch
queue-3.10/target-fix-alua_access_state-attribute-oops-for-un-configured-devices.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html