Re: [PATCH] f2fs: guarantee to write dirty data when enabling checkpoint back

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 09, 2021 at 08:09:05AM +0200, Greg KH wrote:
> On Wed, Sep 08, 2021 at 10:42:53PM -0700, Jaegeuk Kim wrote:
> > On 09/09, Greg KH wrote:
> > > On Wed, Sep 08, 2021 at 10:28:37PM -0700, Jaegeuk Kim wrote:
> > > > On 09/09, Greg KH wrote:
> > > > > On Wed, Sep 08, 2021 at 03:00:20PM -0700, Jaegeuk Kim wrote:
> > > > > > From: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
> > > > > > 
> > > > > > commit dddd3d65293a52c2c3850c19b1e5115712e534d8 upstream.
> > > > > > 
> > > > > > We must flush all the dirty data when enabling checkpoint back. Let's guarantee
> > > > > > that first by adding a retry logic on sync_inodes_sb(). In addition to that,
> > > > > > this patch adds to flush data in fsync when checkpoint is disabled, which can
> > > > > > mitigate the sync_inodes_sb() failures in advance.
> > > > > > 
> > > > > > Reviewed-by: Chao Yu <chao@xxxxxxxxxx>
> > > > > > Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
> > > > > > ---
> > > > > >  fs/f2fs/file.c  |  5 ++---
> > > > > >  fs/f2fs/super.c | 11 ++++++++++-
> > > > > >  2 files changed, 12 insertions(+), 4 deletions(-)
> > > > > 
> > > > > What stable kernel(s) are you wanting to have this backported to?
> > > > 
> > > > 5.10 please.
> > > 
> > > Why would you want to skip 5.14.y and 5.13.y?  You never want anyone to
> > > upgrade stable kernel releases and have a regression.
> > 
> > I was just looking at the essential kernel version, since the fix is only
> > related to checkpoint=disable feature used in android only. Feel free to
> > merge it into any stable kernels if you want.
> 
> No regressions for any stable releases is key here, Android is just one
> user of the kernel...
> 
> And in the future, just put a cc: stable in the signed-off-by area when
> you submit the patch and it will be handled automatically, like the
> documentation states :)

Now queued up.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux