Re: [PATCH for 5.10.y] serial: 8250: 8250_omap: Fix possible array out of bounds access

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 06, 2021 at 03:05:12PM +0900, Nobuhiro Iwamatsu wrote:
> From: Vignesh Raghavendra <vigneshr@xxxxxx>
> 
> commit d4548b14dd7e5c698f81ce23ce7b69a896373b45 upstream.
> 
> k3_soc_devices array is missing a sentinel entry which may result in out
> of bounds access as reported by kernel KASAN.
> 
> Fix this by adding a sentinel entry.
> 
> Fixes: 439c7183e5b9 ("serial: 8250: 8250_omap: Disable RX interrupt after DMA enable")
> Reported-by: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx>
> Signed-off-by: Vignesh Raghavendra <vigneshr@xxxxxx>
> Link: https://lore.kernel.org/r/20201111112653.2710-1-vigneshr@xxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Nobuhiro Iwamatsu (CIP) <nobuhiro1.iwamatsu@xxxxxxxxxxxxx>
> ---
>  drivers/tty/serial/8250/8250_omap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
> index 95e2d6de4f2134..ad0549dac7d792 100644
> --- a/drivers/tty/serial/8250/8250_omap.c
> +++ b/drivers/tty/serial/8250/8250_omap.c
> @@ -1211,6 +1211,7 @@ static int omap8250_no_handle_irq(struct uart_port *port)
>  static const struct soc_device_attribute k3_soc_devices[] = {
>  	{ .family = "AM65X",  },
>  	{ .family = "J721E", .revision = "SR1.0" },
> +	{ /* sentinel */ }
>  };
>  
>  static struct omap8250_dma_params am654_dma = {
> -- 
> 2.33.0
> 
> 

Now queued up, thanks.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux