On Tue, Aug 24, 2021 at 11:57:53PM +0800, DENG Qingfang wrote: > Hi Sasha, > > On Tue, Aug 24, 2021 at 11:29 PM Sasha Levin <sashal@xxxxxxxxxx> wrote: > > What's the reasoning behind: > > > > 1. Backporting this patch? > > Standalone ports should have address learning disabled, according to > the documentation: > https://www.kernel.org/doc/html/v5.14-rc7/networking/dsa/dsa.html#bridge-layer > dsa_switch_ops on 5.10 or earlier does not have .port_bridge_flags > function so it has to be done differently. > > I've identified an issue related to this. What issue is that? Where was it reported? > > 2. A partial backport of this patch? > > The other part does not actually fix anything. Then why is it not ok to just take the whole thing? When backporting not-identical-patches, something almost always goes wrong, so we prefer to take the original commit when ever possible. thanks, greg k-h
