On Tue, Aug 24, 2021 at 01:15:31PM +0100, Pavel Begunkov wrote:
From: Jens Axboe <axboe@xxxxxxxxx> [ upstream commit 21f965221e7c42609521342403e8fb91b8b3e76e ] If an SQPOLL based ring is newly created and an application issues an io_uring_enter(2) system call on it, then we can return a spurious -EOWNERDEAD error. This happens because there's nothing to submit, and if the caller doesn't specify any other action, the initial error assignment of -EOWNERDEAD never gets overwritten. This causes us to return it directly, even if it isn't valid. Move the error assignment into the actual failure case instead. Cc: stable@xxxxxxxxxxxxxxx Fixes: d9d05217cb69 ("io_uring: stop SQPOLL submit on creator's death") Reported-by: Sherlock Holo sherlockya@xxxxxxxxx Link: https://github.com/axboe/liburing/issues/413 Signed-off-by: Jens Axboe <axboe@xxxxxxxxx> Signed-off-by: Pavel Begunkov <asml.silence@xxxxxxxxx>
Queued up, thanks! -- Thanks, Sasha