On Wed, Apr 30, 2014 at 08:09:22PM +0100, Ben Hutchings wrote: > On Wed, 2014-04-30 at 15:08 +0800, Rui Xiang wrote: > > From: Ben Hutchings <ben@xxxxxxxxxxxxxxx> > > > > When backporting commit ebebd49a8eab ('8250/16?50: Add support for > > Broadcom TruManage redirected serial port') I took the next > > available port type number for PORT_BRCM_TRUMANAGE (22). > > > > However, the 8250 port type numbers are exposed to userland through > > the TIOC{G,S}SERIAL ioctls and so must remain stable. Redefine > > PORT_BRCM_TRUMANAGE as 25, matching mainline as of commit > > 85f024401bf807. > > > > This leaves port types 22-24 within the valid range for 8250 but not > > implemented there. Change serial8250_verify_port() to specifically > > reject these and change serial8250_type() to return "unknown" for them > > (though I'm not sure why it would ever see them). > > > > Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx> > > [xr: Backported to 3.4: Adjust filenames] > > Signed-off-by: Rui Xiang <rui.xiang@xxxxxxxxxx> > [...] > > I think this should be folded into 2/4, but it's for Greg to decide. Yes, I've merged it in, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html