Re: [PATCH 4.19.y] tracing: Reject string operand in the histogram expression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 11, 2021 at 04:39:46PM +0900, Masami Hiramatsu wrote:
> commit a9d10ca4986571bffc19778742d508cc8dd13e02 upstream
> 
> Since the string type can not be the target of the addition / subtraction
> operation, it must be rejected. Without this fix, the string type silently
> converted to digits.
> 
> Link: https://lkml.kernel.org/r/162742654278.290973.1523000673366456634.stgit@devnote2
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 100719dcef447 ("tracing: Add simple expression support to hist triggers")
> Signed-off-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> ---
>  - Since there is no hist_err() APIs in 4.19, this just check the flag
>    and return an error without any error messages.
> ---
>  kernel/trace/trace_events_hist.c |   14 ++++++++++++++
>  1 file changed, 14 insertions(+)

Both backports applied, thanks.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux