On Wed, Aug 11, 2021 at 06:50:12PM +0300, Georgi Djakov wrote: > On 10.08.21 20:31, Greg Kroah-Hartman wrote: > > From: Mike Tipton <mdtipton@xxxxxxxxxxxxxx> > > > > commit f84f5b6f72e68bbaeb850b58ac167e4a3a47532a upstream. > > > > We're only adding BCMs to the commit list in aggregate(), but there are > > cases where pre_aggregate() is called without subsequently calling > > aggregate(). In particular, in icc_sync_state() when a node with initial > > BW has zero requests. Since BCMs aren't added to the commit list in > > these cases, we don't actually send the zero BW request to HW. So the > > resources remain on unnecessarily. > > > > Add BCMs to the commit list in pre_aggregate() instead, which is always > > called even when there are no requests. > > > > Fixes: 976daac4a1c5 ("interconnect: qcom: Consolidate interconnect RPMh support") > > Signed-off-by: Mike Tipton <mdtipton@xxxxxxxxxxxxxx> > > Link: https://lore.kernel.org/r/20210721175432.2119-5-mdtipton@xxxxxxxxxxxxxx > > Signed-off-by: Georgi Djakov <djakov@xxxxxxxxxx> > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Hello Greg, > > Please drop this patch, as people are reporting issues on some > platforms. So please do not apply it to any stable trees yet > (5.10 and 5.13). I will send a revert (or other fix) to you soon. Now dropped from both queues, thanks. greg k-h