On Tue, Aug 10, 2021 at 10:52 PM Will Deacon <will@xxxxxxxxxx> wrote: > > [+Masahiro] > > On Mon, Aug 09, 2021 at 07:14:14PM +0000, Andrew Delgadillo wrote: > > commit a5b8ca97fbf8 ("arm64: do not descend to vdso directories twice") > > changes the cleaning behavior of arm64's vdso files, in that vdso.lds, > > vdso.so, and vdso.so.dbg are not removed upon a 'make clean/mrproper': > > > > $ make defconfig ARCH=arm64 > > $ make ARCH=arm64 > > $ make mrproper ARCH=arm64 > > $ git clean -nxdf > > Would remove arch/arm64/kernel/vdso/vdso.lds > > Would remove arch/arm64/kernel/vdso/vdso.so > > Would remove arch/arm64/kernel/vdso/vdso.so.dbg > > > > To remedy this, manually descend into arch/arm64/kernel/vdso upon > > cleaning. > > > > After this commit: > > $ make defconfig ARCH=arm64 > > $ make ARCH=arm64 > > $ make mrproper ARCH=arm64 > > $ git clean -nxdf > > <empty> > > Well spotted! Ah, I missed this. Sorry. Yes, please do this for vdso, and vdso32 as well. > > Signed-off-by: Andrew Delgadillo <adelg@xxxxxxxxxx> > > --- > > arch/arm64/Makefile | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile > > index b52481f0605d..ef6598cb5a9b 100644 > > --- a/arch/arm64/Makefile > > +++ b/arch/arm64/Makefile > > @@ -181,6 +181,7 @@ archprepare: > > # We use MRPROPER_FILES and CLEAN_FILES now > > archclean: > > $(Q)$(MAKE) $(clean)=$(boot) > > + $(Q)$(MAKE) $(clean)=arch/arm64/kernel/vdso > > I think we also need to clean the vdso32 directory here. Please can you > send a v2 with that added? > > Cheers, > > Will -- Best Regards Masahiro Yamada