On Tue, 10 Aug 2021 at 07:57, Sasha Levin <sashal@xxxxxxxxxx> wrote:
>
> On Tue, Aug 10, 2021 at 02:24:21AM +0900, Nobuhiro Iwamatsu wrote:
> >Hi,
> >
> >Build failed commit 6642eb4eb918 ("ARM: imx: add missing iounmap()") on
> >stable-rc/linux-4.19.y.
> >
> >````
> >arch/arm/mach-imx/mmdc.c: In function 'imx_mmdc_probe':
> >arch/arm/mach-imx/mmdc.c:568:2: error: 'err' undeclared (first use in this function)
> > err = imx_mmdc_perf_init(pdev, mmdc_base);
> > ^~~
> >arch/arm/mach-imx/mmdc.c:568:2: note: each undeclared identifier is reported only once for each function it appears in
> >arch/arm/mach-imx/mmdc.c:573:1: error: control reaches end of non-void function [-Werror=return-type]
> > }
> > ^
> >cc1: some warnings being treated as errors
> >make[1]: *** [scripts/Makefile.build:303: arch/arm/mach-imx/mmdc.o] Error 1
LKFT build system also found this build error on arm.
> >
> >````
> >
> >It seems that err has not been declared.
> >I attached a patch which revise this issue.
>
> Thanks for the report. Instead of fixing up 6642eb4eb918 ("ARM: imx: add
> missing iounmap()"), I'll take 9454a0caff6a ("ARM: imx: add mmdc ipg
> clock operation for mmdc") - this way we'll diverge less from upstream.
Thanks for looking into this issue.
- Naresh
