Re: FAILED: patch "[PATCH] pipe: increase minimum default pipe size to 2 pages" failed to apply to 4.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 09, 2021 at 09:04:06PM +0200, Willy Tarreau wrote:
> On Mon, Aug 09, 2021 at 07:40:41PM +0200, Greg Kroah-Hartman wrote:
> > >  fs/pipe.c | 17 ++++++++++++++++-
> > >  1 file changed, 16 insertions(+), 1 deletion(-)
> > 
> > This looks good to me, I'll queue it up in a bit as it's more
> > descriptive than Alex's backport.
> 
> Greg, do you *really* want to backport it to 4.4 ? I mean, if nobody
> faces this issue in 4.4 I can see more risks with the fix that without
> for systems with low memory (or manually tuned memory usage).

I always prefer to merge "known fixes" to the stable kernel trees as
somehow once one person hits a bug, everyone hits it, no matter how long
it was in hiding :)

The additional memory usage here seems low to me, and we backported the
needed accounting changes there a long time ago, and we know that 4.4.y
is being used for build servers as well as other huge hosting providers.
The "tiny" systems that might be on 4.4 are not really updating
themselves to newer kernels from what I can tell.

So I would prefer to take this patch, but am always willing to revert it
if someone reports problems with it, as it keeps us in sync with the
other stable branches, and with upstream, as close as possible.

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux