On Mon, 9 Aug 2021 11:09:47 -0400, Ewan D. Milne wrote:
> The phba->poll_list is traversed in case of an error in lpfc_sli4_hba_setup(),
> so it must be initialized earlier in case the error path is taken.
>
> [ 490.030738] lpfc 0000:65:00.0: 0:1413 Failed to init iocb list.
> [ 490.036661] BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
> [ 490.044485] PGD 0 P4D 0
> [ 490.047027] Oops: 0000 [#1] SMP PTI
> [ 490.050518] CPU: 0 PID: 7 Comm: kworker/0:1 Kdump: loaded Tainted: G I --------- - - 4.18.
> [ 490.060511] Hardware name: Dell Inc. PowerEdge R440/0WKGTH, BIOS 1.4.8 05/22/2018
> [ 490.067994] Workqueue: events work_for_cpu_fn
> [ 490.072371] RIP: 0010:lpfc_sli4_cleanup_poll_list+0x20/0xb0 [lpfc]
> [ 490.078546] Code: cf e9 04 f7 fe ff 0f 1f 40 00 0f 1f 44 00 00 41 57 49 89 ff 41 56 41 55 41 54 4d 8d a79
> [ 490.097291] RSP: 0018:ffffbd1a463dbcc8 EFLAGS: 00010246
> [ 490.102518] RAX: 0000000000008200 RBX: ffff945cdb8c0000 RCX: 0000000000000000
> [ 490.109649] RDX: 0000000000018200 RSI: ffff9468d0e16818 RDI: 0000000000000000
> [ 490.116783] RBP: ffff945cdb8c1740 R08: 00000000000015c5 R09: 0000000000000042
> [ 490.123915] R10: 0000000000000000 R11: ffffbd1a463dbab0 R12: ffff945cdb8c25c0
> [ 490.131049] R13: 00000000fffffff4 R14: 0000000000001800 R15: ffff945cdb8c0000
> [ 490.138182] FS: 0000000000000000(0000) GS:ffff9468d0e00000(0000) knlGS:0000000000000000
> [ 490.146267] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 490.152013] CR2: 0000000000000000 CR3: 000000042ca10002 CR4: 00000000007706f0
> [ 490.159146] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [ 490.166277] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> [ 490.173409] PKRU: 55555554
> [ 490.176123] Call Trace:
> [ 490.178598] lpfc_sli4_queue_destroy+0x7f/0x3c0 [lpfc]
> [ 490.183745] lpfc_sli4_hba_setup+0x1bc7/0x23e0 [lpfc]
> [ 490.188797] ? kernfs_activate+0x63/0x80
> [ 490.192721] ? kernfs_add_one+0xe7/0x130
> [ 490.196647] ? __kernfs_create_file+0x80/0xb0
> [ 490.201020] ? lpfc_pci_probe_one_s4.isra.48+0x46f/0x9e0 [lpfc]
> [ 490.206944] lpfc_pci_probe_one_s4.isra.48+0x46f/0x9e0 [lpfc]
> [ 490.212697] lpfc_pci_probe_one+0x179/0xb70 [lpfc]
> [ 490.217492] local_pci_probe+0x41/0x90
> [ 490.221246] work_for_cpu_fn+0x16/0x20
> [ 490.224994] process_one_work+0x1a7/0x360
> [ 490.229009] ? create_worker+0x1a0/0x1a0
> [ 490.232933] worker_thread+0x1cf/0x390
> [ 490.236687] ? create_worker+0x1a0/0x1a0
> [ 490.240612] kthread+0x116/0x130
> [ 490.243846] ? kthread_flush_work_fn+0x10/0x10
> [ 490.248293] ret_from_fork+0x35/0x40
> [ 490.251869] Modules linked in: lpfc(+) xt_CHECKSUM ipt_MASQUERADE xt_conntrack ipt_REJECT nf_reject_ipv4i
> [ 490.332609] CR2: 0000000000000000
>
> [...]
Applied to 5.14/scsi-fixes, thanks!
[1/1] lpfc: move initialization of phba->poll_list earlier to avoid crash
https://git.kernel.org/mkp/scsi/c/9977d880f7a3
--
Martin K. Petersen Oracle Linux Engineering
