Re: [PATCH] NIU: fix missing revert of return and fix the driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Paul Jakma <paul@xxxxxxxxx>
Date: Tue, 20 Jul 2021 21:10:37 +0100 (BST)

> The revert of commit 26fd962 missed out on reverting an incorrect
> change to a return value. The niu_pci_vpd_scan_props(..) == 1 case
> appears to be a normal path - treating it as an error and return
> -EINVAL was breaking VPD_SCAN and causing the driver to fail to load.
> 
> Fix it, so my Neptune card works again.
> 
> Cc: Kangjie Lu <kjlu@xxxxxxx>
> Cc: Shannon Nelson <shannon.lee.nelson@xxxxxxxxx>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Fixes: 7930742d ('Revert "niu: fix missing checks of
> niu_pci_eeprom_read"')
> Cc: stable <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Paul Jakma <paul@xxxxxxxxx>
> ---

This does not apply to the current networking GIT tree, what tree is it against?

Thank you.



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux