On Sat, Jul 17, 2021 at 2:48 PM Moritz Fischer <mdf@xxxxxxxxxx> wrote: > > On Sat, Jul 17, 2021 at 07:34:51PM +0200, Greg Kroah-Hartman wrote: > > On Sat, Jul 17, 2021 at 08:39:19AM -0500, Justin Forbes wrote: > > > On Mon, Jul 12, 2021 at 2:31 AM Greg Kroah-Hartman > > > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > > > > From: Moritz Fischer <mdf@xxxxxxxxxx> > > > > > > > > commit d143825baf15f204dac60acdf95e428182aa3374 upstream. > > > > > > > > The ROM load sometimes seems to return an unknown status > > > > (RENESAS_ROM_STATUS_NO_RESULT) instead of success / fail. > > > > > > > > If the ROM load indeed failed this leads to failures when trying to > > > > communicate with the controller later on. > > > > > > > > Attempt to load firmware using RAM load in those cases. > > > > > > > > Fixes: 2478be82de44 ("usb: renesas-xhci: Add ROM loader for uPD720201") > > > > Cc: stable@xxxxxxxxxxxxxxx > > > > Cc: Mathias Nyman <mathias.nyman@xxxxxxxxx> > > > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > > Cc: Vinod Koul <vkoul@xxxxxxxxxx> > > > > Tested-by: Vinod Koul <vkoul@xxxxxxxxxx> > > > > Reviewed-by: Vinod Koul <vkoul@xxxxxxxxxx> > > > > Signed-off-by: Moritz Fischer <mdf@xxxxxxxxxx> > > > > Link: https://lore.kernel.org/r/20210615153758.253572-1-mdf@xxxxxxxxxx > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > > > > > > > > After sending out 5.12.17 for testing, we had a user complain that all > > > of their USB devices disappeared with the error: > > > > > > Jul 15 23:18:53 kernel: xhci_hcd 0000:04:00.0: Direct firmware load > > > for renesas_usb_fw.mem failed with error -2 > > > Jul 15 23:18:53 kernel: xhci_hcd 0000:04:00.0: request_firmware failed: -2 > > > Jul 15 23:18:53 kernel: xhci_hcd: probe of 0000:04:00.0 failed with error -2 > > > > > > After first assuming that something was missing in the backport to > > > 5.12, I had the user try 5.13.2, and then 5.14-rc1. Both of those > > > failed in the same way, so it is not working in the current Linus tree > > > either. Reverting this patch fixed the issue. > > > > Can you send a revert for this so I can get that into Linus's tree and > > then all stable releases as well? > > > > thanks, > > > > greg k-h > > Me or Justin? I can do it. This is annoying my system doesn't work > without this :-( > > Back to the drawing board I guess ... > > Justin, any idea if your customer had the eeprom populated and > programmed or not, just as additional datapoint. I am not sure, but I did have another user chime in on the bug saying the test kernel with the revert fixed their system as well. It was a T14s AMD Generation_1. The original reporter had a ASUS System Product Name/PRIME H370M-PLUS, BIOS 2801 04/13/2021. Justin > - Moritz