Hi,
On Fri, Jul 09, 2021 at 09:24:08PM +0800, Gao Xiang wrote:
> commit a510b616131f85215ba156ed67e5ed1c0701f80f upstream.
>
> kernel test robot reported a 5.4.y build issue found by randconfig [1]
> after backporting commit 89b158635ad7 ("lib/lz4: explicitly support
> in-place decompression""). This isn't a problem for v5.10+ since
> commit a510b616131f ("MIPS: Add support for ZSTD-compressed kernels")
> which wasn't included in v5.4, but included in v5.10.y, so only v5.4.y
> is effected.
>
> This partially cherry-picks the memmove part of commit a510b616131f
> to fix the reported build issue for v5.4.y stable only. Hopefully
> kernelci could also double check this.
>
> [1] https://lore.kernel.org/r/202107070120.6dOj1kB7-lkp@xxxxxxxxx/
> Fixes: defcc2b5e54a ("lib/lz4: explicitly support in-place decompression") # 5.4.y
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Gao Xiang <hsiangkao@xxxxxxxxxxxxxxxxx>
> ---
> not sure if the stable-only patch format is like this, it partially
> cherry-picks the useful memmove part of commit a510b616131f to fix
> the build issue found by randconfig fuzz only.
ping.. are there more things I can do for this?
Thanks,
Gao Xiang
>
> arch/mips/boot/compressed/string.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/mips/boot/compressed/string.c b/arch/mips/boot/compressed/string.c
> index 43beecc3587c..e9ab7ea592ba 100644
> --- a/arch/mips/boot/compressed/string.c
> +++ b/arch/mips/boot/compressed/string.c
> @@ -27,3 +27,19 @@ void *memset(void *s, int c, size_t n)
> ss[i] = c;
> return s;
> }
> +
> +void * __weak memmove(void *dest, const void *src, size_t n)
> +{
> + unsigned int i;
> + const char *s = src;
> + char *d = dest;
> +
> + if ((uintptr_t)dest < (uintptr_t)src) {
> + for (i = 0; i < n; i++)
> + d[i] = s[i];
> + } else {
> + for (i = n; i > 0; i--)
> + d[i - 1] = s[i - 1];
> + }
> + return dest;
> +}
> --
> 2.24.4
