Re: [PATCH] x86/entry: Fix noinstr violation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 08, 2021 at 08:37:30PM +0200, Thomas Gleixner wrote:
> On Thu, Jul 08 2021 at 15:37, Thomas Gleixner wrote:
> > The recent commit which fixed the entry/exit mismatch on failed 32-bit
> > syscalls got the ordering vs. instrumentation_end() wrong, which makes
> > objtool complain about tracer invocation in an instrumentation disabled
> > region.
> >
> > Stick the offending local_irq_disable() into the instrumentation enabled
> > region so objtool stops complaining.
> >
> > Fixes: 5d5675df792f ("x86/entry: Fix entry/exit mismatch on failed fast 32-bit syscalls")
> 
> Bah. I looked at the wrong branch. It's fixed already in Linus tree:
> 
> commit 240001d4e3041832e8a2654adc3ccf1683132b92
> Author: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Date:   Mon Jun 21 13:12:34 2021 +0200
> 
>     x86/entry: Fix noinstr fail in __do_fast_syscall_32()
> 
> Though that lacks a CC: stable tag, which would have been appropriate
> because 5d5675df792f ("x86/entry: Fix entry/exit mismatch on failed fast
> 32-bit syscalls") has been backported.
> 
> Can the stable folks pick this up please?

It's already in 5.10.47 and 5.12.14.  Does it need to go further back to
older kernels?

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux