This is a note to let you know that I've just added the patch titled thinkpad-acpi: fix issuing duplicated key events for brightness up/down to the 3.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: thinkpad-acpi-fix-issuing-duplicated-key-events-for-brightness-up-down.patch and it can be found in the queue-3.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From ff413195e830541afeae469fc866ecd0319abd7e Mon Sep 17 00:00:00 2001 From: Alex Hung <alex.hung@xxxxxxxxxxxxx> Date: Tue, 24 Apr 2012 16:40:52 +0800 Subject: thinkpad-acpi: fix issuing duplicated key events for brightness up/down From: Alex Hung <alex.hung@xxxxxxxxxxxxx> commit ff413195e830541afeae469fc866ecd0319abd7e upstream. The tp_features.bright_acpimode will not be set correctly for brightness control because ACPI_VIDEO_HID will not be located in ACPI. As a result, a duplicated key event will always be sent. acpi_video_backlight_support() is sufficient to detect standard ACPI brightness control. Signed-off-by: Alex Hung <alex.hung@xxxxxxxxxxxxx> Signed-off-by: Matthew Garrett <mjg@xxxxxxxxxx> Cc: Andreas Sturmlechner <andreas.sturmlechner@xxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/platform/x86/thinkpad_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -3402,7 +3402,7 @@ static int __init hotkey_init(struct ibm /* Do not issue duplicate brightness change events to * userspace. tpacpi_detect_brightness_capabilities() must have * been called before this point */ - if (tp_features.bright_acpimode && acpi_video_backlight_support()) { + if (acpi_video_backlight_support()) { pr_info("This ThinkPad has standard ACPI backlight " "brightness control, supported by the ACPI " "video driver\n"); Patches currently in stable-queue which might be from alex.hung@xxxxxxxxxxxxx are queue-3.4/thinkpad-acpi-fix-issuing-duplicated-key-events-for-brightness-up-down.patch -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html