On Thu, Jul 1, 2021 at 5:07 PM Joe Perches <joe@xxxxxxxxxxx> wrote: > > On 2021-07-01 12:51, Steven Rostedt wrote: > > On Thu, 01 Jul 2021 12:35:29 -0700 > > Joe Perches <joe@xxxxxxxxxxx> wrote: > > > >> C99 comments are allowed since about 5 years ago. > > > > Really, I thought Linus hated them. Personally, I find them rather ugly > > myself. The only user of them I see in the kernel/ directory appears to > > be for RCU. But Paul's on the C/C++ committee, so perhaps he favors > > them. > > > > The net/ directory doesn't have any, except perhaps to comment out code > > (which I sometimes use it for that too). > > > > The block/, arch/x86/ directories don't have them either. > > > > I wouldn't go and change checkpatch, but I still rather avoid them, > > especially for multi line comments. > > > > /* > > * When it comes to multi line comments I prefer using something > > * that denotes a start and an end to the comment, as it makes it > > * look like a nice clip of information. > > */ > > > > Instead of: > > > > // When it comes to multi line comments I prefer using something > > // that denotes a start and an end to the comment, as it makes it > > // look like a nice clip of information. > > > > Which just looks like noise. But hey, maybe that's just me because I > > find "*" as a sign of information and '//' something to ignore. ;-) > > May I suggest using something other than an amber vt220? Steve - mostly comments are to be ignored and the code is the ultimate source of truth ;-), so // is fine :-D That said, don't discard the amber vt220 I recently sent you just because Joe says so ;-) <:o) - Joel