On Wed, 30 Jun 2021 19:11:45 -0400 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > On Wed, 30 Jun 2021 18:34:11 -0400 > Joel Fernandes <joelaf@xxxxxxxxxx> wrote: > > > > Anyway, I'll wait to hear what Joel says on this. If he thinks this is > > > worth 16M of memory when enabled, I may take it. > > > > I am not a huge fan of the 16M, in Android we enable this feature on > > all devices. Low end Android devices traced in the field are sometimes > > 1 GB and the added memory pressure may be unwelcome. Very least, maybe > > make it optional only for folks who increase pid_max? > > Yeah, can we just set it to the size of pid_max, at whatever it is set > to? Can you send a V2 with this update and address Joel's comments to patch 1, and get it to me today? I plan on sending Linus a pull request tomorrow, which means I have to kick off my tests tonight for what I want to send. -- Steve
