On 6/24/2021 5:04 AM, Sasha Levin wrote:
On Wed, Jun 23, 2021 at 10:26:12AM -0700, Nathan Chancellor wrote:
commit 885480b084696331bea61a4f7eba10652999a9c1 upstream.
Currently, -Wunused-but-set-variable is only supported by GCC so it is
disabled unconditionally in a GCC only block (it is enabled with W=1).
clang currently has its implementation for this warning in review so
preemptively move this statement out of the GCC only block and wrap it
with cc-disable-warning so that both compilers function the same.
Cc: stable@xxxxxxxxxxxxxxx
Link: https://reviews.llvm.org/D100581
Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
Tested-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
[nc: Backport, workaround lack of e2079e93f562 in older branches]
Can we just take the above patch instead?
No because that patch has a prerequisite of commit a035d552a93b
("Makefile: Globally enable fall-through warning"), which is not
suitable for stable because there were hundreds of warnings fixed before
that was enabled.
Cheers,
Nathan
