On Fri 2021-05-14 16:44:37, Michal Vokáč wrote:
> Since the LED multicolor framework support was added in commit
> 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
> LEDs on this platform stopped working.
>
> Author of the framework attempted to accommodate this DT to the
> framework in commit b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property
> to the lp5562 channel node") but that is not sufficient. A color property
> is now required even if the multicolor framework is not used, otherwise
> the driver probe fails:
>
> lp5562: probe of 1-0030 failed with error -22
>
> Add the color property to fix this and remove the actually unused white
> channel.
>
> Fixes: b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node")
I believe this is for arm maintainers to take...
> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> index 7d2c72562c73..3107bf7fbce5 100644
> --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> @@ -5,6 +5,7 @@
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
> #include <dt-bindings/pwm/pwm.h>
>
> / {
> @@ -271,6 +272,7 @@
> led-cur = /bits/ 8 <0x20>;
> max-cur = /bits/ 8 <0x60>;
> reg = <0>;
> + color = <LED_COLOR_ID_RED>;
> };
>
> chan@1 {
> @@ -278,6 +280,7 @@
> led-cur = /bits/ 8 <0x20>;
> max-cur = /bits/ 8 <0x60>;
> reg = <1>;
> + color = <LED_COLOR_ID_GREEN>;
> };
>
> chan@2 {
> @@ -285,13 +288,7 @@
> led-cur = /bits/ 8 <0x20>;
> max-cur = /bits/ 8 <0x60>;
> reg = <2>;
> - };
> -
> - chan@3 {
> - chan-name = "W";
> - led-cur = /bits/ 8 <0x0>;
> - max-cur = /bits/ 8 <0x0>;
> - reg = <3>;
> + color = <LED_COLOR_ID_BLUE>;
> };
> };
>
What is going on here? "White" channel seems to have disappeared?
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
Attachment:
signature.asc
Description: Digital signature
