This is a note to let you know that I've just added the patch titled
target: Allow non-supporting backends to set pi_prot_type to 0
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
target-allow-non-supporting-backends-to-set-pi_prot_type-to-0.patch
and it can be found in the queue-3.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 448ba904160f9d8f69217c28a1692cee5afbff88 Mon Sep 17 00:00:00 2001
From: Andy Grover <agrover@xxxxxxxxxx>
Date: Tue, 15 Apr 2014 14:13:12 -0700
Subject: target: Allow non-supporting backends to set pi_prot_type to 0
From: Andy Grover <agrover@xxxxxxxxxx>
commit 448ba904160f9d8f69217c28a1692cee5afbff88 upstream.
Userspace tools assume if a value is read from configfs, it is valid
and will not cause an error if the same value is written back. The only
valid value for pi_prot_type for backends not supporting DIF is 0, so allow
this particular value to be set without returning an error.
Reported-by: Krzysztof Chojnowski <frirajder@xxxxxxxxx>
Signed-off-by: Andy Grover <agrover@xxxxxxxxxx>
Reviewed-by: Sagi Grimberg <sagig@xxxxxxxxxxxx>
Signed-off-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/target/target_core_device.c | 4 ++++
1 file changed, 4 insertions(+)
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -936,6 +936,10 @@ int se_dev_set_pi_prot_type(struct se_de
return 0;
}
if (!dev->transport->init_prot || !dev->transport->free_prot) {
+ /* 0 is only allowed value for non-supporting backends */
+ if (flag == 0)
+ return 0;
+
pr_err("DIF protection not supported by backend: %s\n",
dev->transport->name);
return -ENOSYS;
Patches currently in stable-queue which might be from agrover@xxxxxxxxxx are
queue-3.14/target-allow-non-supporting-backends-to-set-pi_prot_type-to-0.patch
queue-3.14/target-don-t-allow-setting-wc-emulation-if-device-doesn-t-support.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html