On 18/06/2021 10:57, Krzysztof Kozlowski wrote: > On 10/05/2021 12:18, Greg Kroah-Hartman wrote: >> From: Christoph Hellwig <hch@xxxxxx> >> >> commit 262e6ae7081df304fc625cf368d5c2cbba2bb991 upstream. >> >> If a TAINT_PROPRIETARY_MODULE exports symbol, inherit the taint flag >> for all modules importing these symbols, and don't allow loading >> symbols from TAINT_PROPRIETARY_MODULE modules if the module previously >> imported gplonly symbols. Add a anti-circumvention devices so people >> don't accidentally get themselves into trouble this way. >> >> Comment from Greg: >> "Ah, the proven-to-be-illegal "GPL Condom" defense :)" > > Patch got in to stable, so my comments are quite late, but can someone > explain me - how this is a stable material? What specific, real bug that > bothers people, is being fixed here? Or maybe it fixes serious issue > reported by a user of distribution kernel? IOW, how does this match > stable kernel rules at all? > > For sure it breaks some out-of-tree modules already present and used by > customers of downstream stable kernels. Therefore I wonder what is the > bug fixed here, so the breakage and annoyance of stable users is justified. And for the record I am not talking about this patch only. I am asking also what serious or real bug is being fixed by: "modules: mark find_symbol static find_symbol is only used in module.c." I would be really happy to extend my knowledge about real bugs faced by people, where the fix is to un-export unused symbol. It must have been very interesting, real bug bothering people. :) Best regards, Krzysztof
