This is a note to let you know that I've just added the patch titled
nfsd4: warn on finding lockowner without stateid's
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
nfsd4-warn-on-finding-lockowner-without-stateid-s.patch
and it can be found in the queue-3.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 27b11428b7de097c42f205beabb1764f4365443b Mon Sep 17 00:00:00 2001
From: "J. Bruce Fields" <bfields@xxxxxxxxxx>
Date: Thu, 8 May 2014 11:19:41 -0400
Subject: nfsd4: warn on finding lockowner without stateid's
From: "J. Bruce Fields" <bfields@xxxxxxxxxx>
commit 27b11428b7de097c42f205beabb1764f4365443b upstream.
The current code assumes a one-to-one lockowner<->lock stateid
correspondance.
Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/nfsd/nfs4state.c | 4 ++++
1 file changed, 4 insertions(+)
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -4156,6 +4156,10 @@ static bool same_lockowner_ino(struct nf
if (!same_owner_str(&lo->lo_owner, owner, clid))
return false;
+ if (list_empty(&lo->lo_owner.so_stateids)) {
+ WARN_ON_ONCE(1);
+ return false;
+ }
lst = list_first_entry(&lo->lo_owner.so_stateids,
struct nfs4_ol_stateid, st_perstateowner);
return lst->st_file->fi_inode == inode;
Patches currently in stable-queue which might be from bfields@xxxxxxxxxx are
queue-3.14/nfsd4-remove-lockowner-when-removing-lock-stateid.patch
queue-3.14/nfsd-move-default-initialisers-from-create_client-to.patch
queue-3.14/nfsd-call-set_acl-with-a-null-acl-structure-if-no-entries.patch
queue-3.14/nfsd4-warn-on-finding-lockowner-without-stateid-s.patch
queue-3.14/nfsd-call-rpc_destroy_wait_queue-from-free_client.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html