On Wed, Jun 9, 2021 at 1:52 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > That said, even though I'm almost done with my tests on this patch, and > was going to send you a pull request later today, I can hold off and > have Liangyan send a v2 using struct_size and with the clean ups you > suggested. I think the cleanups could be separate. I in no way _hate_ Liangyan's patch, it's just that when looking at it I just went "that code is very confusing". So I'm certainly also ok with just getting that ugly fix, and then hope for a cleanup later. Maybe with a comment or two. Thanks, Linus