Re: [PATCH] nsfs: fix oops when ns->ops is not provided

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2 Jun 2021 11:16:32 +0200 Christian Brauner wrote:
> > diff --git a/net/socket.c b/net/socket.c
> > index 27e3e7d53f8e..3b44f2700e0c 100644
> > --- a/net/socket.c
> > +++ b/net/socket.c
> > @@ -1081,6 +1081,8 @@ static long sock_do_ioctl(struct net *net, struct socket *sock,
> >  
> >  struct ns_common *get_net_ns(struct ns_common *ns)
> >  {
> > +       if (!IS_ENABLED(CONFIG_NET_NS))
> > +               return ERR_PTR(-EOPNOTSUPP);
> >         return &get_net(container_of(ns, struct net, ns))->ns;
> >  }
> >  EXPORT_SYMBOL_GPL(get_net_ns);  
> 
> Yeah, that's better than my hack. :) Maybe this function should simply
> move over to net/core/net_namespace.c with the other netns getters, e.g.
> get_net_ns_by_fd()?

SGTM!



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux