Re: [PATCH] crypto: sm2 - fix a memory leak in sm2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hongbo,

On 5/31/21 9:30 PM, Hongbo Li wrote:
From: Hongbo Li <herberthbli@xxxxxxxxxxx>

SM2 module alloc ec->Q in sm2_set_pub_key(), when doing alg test in
test_akcipher_one(), it will set public key for every test vector,
and don't free ec->Q. This will cause a memory leak.

This patch alloc ec->Q in sm2_ec_ctx_init().

Fixes: ea7ecb66440b ("crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm")
Signed-off-by: Hongbo Li <herberthbli@xxxxxxxxxxx>
Reviewed-by: Tianjia Zhang <tianjia.zhang@xxxxxxxxxxxxxxxxx>
---
  crypto/sm2.c | 24 ++++++++++--------------
  1 file changed, 10 insertions(+), 14 deletions(-)


Just add Cc: to SOB, like this:

  Fixes: ea7ecb66440b (...)
  Signed-off-by: Hongbo Li <herberthbli@xxxxxxxxxxx>
  Cc: stable@xxxxxxxxxxxxxxx # v5.10+
  Reviewed-by: Tianjia Zhang <tianjia.zhang@xxxxxxxxxxxxxxxxx>

Thanks,
Tianjia



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux