From: Doug Smythies <dsmythies@xxxxxxxxx> This change makes the busy calculation using 64 bit math which prevents overflow for large values of aperf/mperf. Cc: <stable@xxxxxxxxxxxxxxx> # 3.14.x Signed-off-by: Doug Smythies <dsmythies@xxxxxxxxx> Signed-off-by: Dirk Brandewie <dirk.j.brandewie@xxxxxxxxx> --- drivers/cpufreq/intel_pstate.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index c4dad16..774d277 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -556,16 +556,19 @@ static void intel_pstate_get_cpu_pstates(struct cpudata *cpu) static inline void intel_pstate_calc_busy(struct cpudata *cpu) { - struct sample *sample = &cpu->sample; - int32_t core_pct; + int64_t core_pct; + int32_t rem; - core_pct = div_fp(int_tofp(sample->aperf), int_tofp(sample->mperf)); - core_pct = mul_fp(core_pct, int_tofp(100)); + core_pct = int_tofp(sample->aperf) * int_tofp(100); + core_pct = div_u64_rem(core_pct, int_tofp(sample->mperf), &rem); + + if ((rem << 1) >= int_tofp((sample->mperf))) + core_pct += 1; sample->freq = fp_toint( mul_fp(int_tofp(cpu->pstate.max_pstate * 1000), core_pct)); - sample->core_pct_busy = core_pct; + sample->core_pct_busy = (int32_t)core_pct; } static inline void intel_pstate_sample(struct cpudata *cpu) -- 1.9.0 -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html