Re: [PATCH for 4.4, 4.9 and 4.14] xhci: Do not use GFP_KERNEL in (potentially) atomic context

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 18, 2021 at 12:30:35PM +0900, Nobuhiro Iwamatsu wrote:
> From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> 
> commit dda32c00c9a0fa103b5d54ef72c477b7aa993679 upstream.
> 
> 'xhci_urb_enqueue()' is passed a 'mem_flags' argument, because "URBs may be
> submitted in interrupt context" (see comment related to 'usb_submit_urb()'
> in 'drivers/usb/core/urb.c')
> 
> So this flag should be used in all the calling chain.
> Up to now, 'xhci_check_maxpacket()' which is only called from
> 'xhci_urb_enqueue()', uses GFP_KERNEL.
> 
> Be safe and pass the mem_flags to this function as well.
> 
> Fixes: ddba5cd0aeff ("xhci: Use command structures when queuing commands on the command ring")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> Link: https://lore.kernel.org/r/20210512080816.866037-4-mathias.nyman@xxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> [iwamatsu: Adjust context]
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx>

Now queued up, thanks.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux