On Sun, May 16, 2021 at 04:01:09PM +0200, Maciej W. Rozycki wrote: > On Sun, 16 May 2021, Greg KH wrote: > > > > Reported-by: Huacai Chen <chenhuacai@xxxxxxxxxx> > > > Signed-off-by: Maciej W. Rozycki <macro@xxxxxxxxxxx> > > > Fixes: c21004cd5b4c ("MIPS: Rewrite <asm/div64.h> to work with gcc 4.4.0.") > > > Cc: stable@xxxxxxxxxxxxxxx # v2.6.30+ > > > --- > > > Hi, > > > > > > This is a backported version of commit c49f71f60754 with a fix for MIPSr6 > > > compilation, that is commit 25ab14cbe9d1 included and the commit message > > > amended accordingly. I have folded intermediate commit c1d337d45ec0 into > > > this change as well, as trivially obvious and mechanically in the way > > > between the two former changes, though strictly speaking an enhancement > > > rather than a fix. This way the state between master and stable branches > > > is consistent. > > > > > > Rationale: the three changes could be applied separately as with master, > > > however we'd have an unnecessary intermediate MIPSr6 build regression, > > > which caused the drop of the original fix. > > > > > > This is for 5.12-stable and before. Let me know if you'd prefer me to > > > resolve this differently, or otherwise please apply. > > > > > > NB verified with a couple of representative defconfigs and booted on hw > > > where available (with the test_div64 test module backported and enabled). > > > > I would prefer to take the same exact commits that are in Linus's tree, > > that makes it easier to track over time and ensure that we have this > > correct. > > > > So what commit ids should I apply in what order? > > Sure, this will be commits: c49f71f60754, c1d337d45ec0, 25ab14cbe9d1 in > the order given. Wonderful, all now queued up, thanks. greg k-h