RDMA/i40iw: Avoid panic when reading back the IRQ affinity hint

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello stable team,

Please consider adding the following upstream commit to the 4.14 stable series:

commit 43731753c4b7d832775cf6b2301dd0447a5a1851
Author: Andrew Boyer <andrew.boyer@xxxxxxxx>
Date:   Mon May 7 13:23:38 2018 -0400

RDMA/i40iw: Avoid panic when reading back the IRQ affinity hint

The current code sets an affinity hint with a cpumask_t stored on the
stack. This value can then be accessed through /proc/irq/*/affinity_hint/,
causing a segfault or returning corrupt data.

Move the cpumask_t into struct i40iw_msix_vector so it is available later.
...
...
...
Fixes: 8e06af711bf2 ("i40iw: add main, hdr, status")
Signed-off-by: Andrew Boyer <andrew.boyer@xxxxxxxx>
Reviewed-by: Shiraz Saleem <shiraz.saleem@xxxxxxxxx>
Signed-off-by: Doug Ledford <dledford@xxxxxxxxxx>

Note, the fixes tag above appears to be incorrect. The problem was
introduced in:

commit e69c5093617afdbd2ab02c289d0adaac044dff66
Author: Henry Orosco <henry.orosco@xxxxxxxxx>
Date:   Wed Nov 9 21:24:48 2016 -0600

i40iw: Use vector when creating CQs

Assign each CEQ vector to a different CPU when possible, then
when creating a CQ, use the vector for the CEQ id. This
allows completion work to be distributed over multiple cores.

Signed-off-by: Mustafa Ismail <mustafa.ismail@xxxxxxxxx>
Signed-off-by: Henry Orosco <henry.orosco@xxxxxxxxx>
Signed-off-by: Doug Ledford <dledford@xxxxxxxxxx>

Thus, affected kernels range from 4.10 to pre 4.17.

Regards,
Edwin Peer

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux