This is a note to let you know that I've just added the patch titled
net-gro: reset skb->truesize in napi_reuse_skb()
to the 3.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-gro-reset-skb-truesize-in-napi_reuse_skb.patch
and it can be found in the queue-3.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From foo@baz Wed May 28 20:24:34 PDT 2014
From: Eric Dumazet <edumazet@xxxxxxxxxx>
Date: Thu, 3 Apr 2014 09:28:10 -0700
Subject: net-gro: reset skb->truesize in napi_reuse_skb()
From: Eric Dumazet <edumazet@xxxxxxxxxx>
[ Upstream commit e33d0ba8047b049c9262fdb1fcafb93cb52ceceb ]
Recycling skb always had been very tough...
This time it appears GRO layer can accumulate skb->truesize
adjustments made by drivers when they attach a fragment to skb.
skb_gro_receive() can only subtract from skb->truesize the used part
of a fragment.
I spotted this problem seeing TcpExtPruneCalled and
TcpExtTCPRcvCollapsed that were unexpected with a recent kernel, where
TCP receive window should be sized properly to accept traffic coming
from a driver not overshooting skb->truesize.
Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
net/core/dev.c | 1 +
1 file changed, 1 insertion(+)
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3574,6 +3574,7 @@ static void napi_reuse_skb(struct napi_s
skb->vlan_tci = 0;
skb->dev = napi->dev;
skb->skb_iif = 0;
+ skb->truesize = SKB_TRUESIZE(skb_end_offset(skb));
napi->skb = skb;
}
Patches currently in stable-queue which might be from edumazet@xxxxxxxxxx are
queue-3.4/skb-add-inline-helper-for-getting-the-skb-end-offset-from-head.patch
queue-3.4/ipv6-limit-mtu-to-65575-bytes.patch
queue-3.4/tcp_cubic-fix-the-range-of-delayed_ack.patch
queue-3.4/net-gro-reset-skb-truesize-in-napi_reuse_skb.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html