On 2014/5/26 21:51, Willy Tarreau wrote: > Hi Wang, > > On Mon, May 26, 2014 at 05:14:09PM +0800, Wang Weidong wrote: >> Hi Willy, >> >> e596e6e4d578f2639416e620d367a3af34814a40 >> ethtool: Report link-down while interface is down >> >> When I add slaves to bonding(bond0), the bond0 is down while >> ethtool gets the Link detected: yes. This commit fix it. >> Looks applicable to stable 2.6.32, it was built successfully >> for me. what do you think? > > I think we can apply it, but I'm a bit surprized, because we're using > 2.6.32 in our products and heavily use bonding. We've run extensive > tests in a number of situations and did not find any remaining issue. > Could you please describe the exact scenario you're using to reproduce > this issue ? Maybe it simply cannot happen in our case, which would > explain why we didn't see it. > > Thanks, > Willy > > OK. ~ # modprobe bonding ~ # ethtool bond0 Settings for bond0: Link detected: no ~ # ifconfig eth1 down ~ # echo +eth1 > /sys/class/net/bond0/bonding/slaves ~ # ethtool bond0 Settings for bond0: Link detected: *yes* *Here*, use 'ip link show bond0' we can see the state is *DOWN*, but the ethtool report is yes, which is wrong. And then, we do that 'ifconfig bond0 down; ethtool bond0', we get the wrong report "Link detected: yes". Regards, Wang > -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html