On Wed, May 14, 2014 at 12:50:20PM +0300, Dan Carpenter wrote: > On Tue, May 13, 2014 at 12:08:12PM +0100, Luis Henriques wrote: > > > diff --git a/fs/xfs/linux-2.6/xfs_ioctl32.c b/fs/xfs/linux-2.6/xfs_ioctl32.c > > > index bad485a..782d03d 100644 > > > --- a/fs/xfs/linux-2.6/xfs_ioctl32.c > > > +++ b/fs/xfs/linux-2.6/xfs_ioctl32.c > > > @@ -361,8 +361,8 @@ xfs_compat_attrlist_by_handle( > > > if (copy_from_user(&al_hreq, arg, > > > sizeof(compat_xfs_fsop_attrlist_handlereq_t))) > > > return -XFS_ERROR(EFAULT); > > > - if (al_hreq.buflen > XATTR_LIST_MAX) > > > - return -XFS_ERROR(EINVAL); > > > > Am I missing something or was the above return statement deleted by > > mistake? > > > > Cheers, > > -- > > Luís > > Good eye. I have created a Smatch check to look for these bugs. > Oh. It turns out checkpatch.pl catches this bug as well. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html